Skip to content

Conversation

soar
Copy link
Contributor

@soar soar commented Apr 7, 2017

At this moment, when you call .tags() - you'll get error:

Traceback (most recent call last):
  File "test-docker.py", line 154, in <module>
    repo.tags()
  File "lib/dockerregistryclient/docker_registry_client/Repository.py", line 42, in tags
    return list(self._images.keys())
AttributeError: 'list' object has no attribute 'keys'

So self._images is list of dictionaries and has no keys() method.

Tested on python 3.5.2 and api_version=1.

@@ -1,7 +1,7 @@
from __future__ import absolute_import

from docker_registry_client._BaseClient import BaseClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently took over the maintenance of this project for my company and I'm a bit rusty on my python knowledge. What are the ramifications of these import statements? Will they break backward compatibility with older python versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkaldon the import won't break backwards compatibility, but it does provide forward compatibility.

@markdrago markdrago merged commit 9069300 into yodle:master Apr 8, 2017
@soar
Copy link
Contributor Author

soar commented Apr 8, 2017

Thank you!

@soar
Copy link
Contributor Author

soar commented Apr 18, 2017

Need this change in pip repository...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants