fix(acp): improve process cleanup and add type annotations #2799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACP processes were not being closed, leaving behind orphan zombie processes.
In my machine, I had more than
30zombie processes.The previous
transport_self.process:close()only closes the communication between Neovim and the spawned process, but it doesn't kill the process.Now, it sends
15to start a graceful exit flow, and if it gets stuck, it sends a force termination with9.Changes
How to test
Before, original behaviour:
:qaps aux | grep <your acp provider name, mine is claude-code-acp>Using these changes
After step 4, exit with
:qaand then run step 5.You should see
0orphan processes.