fix: remove inaccurate and unnecessary regexp used by unknown-options-as-args #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isUnknownOption
contained three similar regular expressions about characters after a flag. After investigation, and consistent with the examples in the comments, I believe they are related to short option group processing (so the-+
at start of pattern is too permissive). But in fact they are not needed at all, because the cases are covered byhasAllShortFlags()
!After deleting the expressions all the existing tests still pass. Also fixes #501. I have copied across the tests from #502 and added @Xunnamius as a co-author on this PR.
Resolves #501
Closes #502