fix: address bugs with "uknown-options-as-args" #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226.
Fixes 3 bugs in hasAnyFlag:
...
insideconcat
flattens all arrays. So ifflags.string
(for example) is an array of string,toCheck
does not contain this array of string, but the strings directly. And a few lines below, ifflag
is a string,flag[repeat]
evaluates to true (as with any method names of String.prototype)flag
is now an array,flag[some]
evaluates to true (Array.prototype...)flag
is an objectBy the way, yargs-parser crashes when passing a
--toString
option: I thing this kind of bug has to be tracked everywhere in the code (I will open another issue for this).