Mechanic for the City destroy #13742
Conversation
removed destroy all city
| } else | ||
| } else if (attacker.unit.hasUnique(UniqueType.CanDestroyCities)) { | ||
| if (defender.city.isCapital()) { | ||
| conquerCity(defender.city, attacker) // Capital is captured |
There was a problem hiding this comment.
... What?
If a range unit has 'can destroy cities' then it can capture capital cities?
There was a problem hiding this comment.
Also if a unit has can destroy and also can't capture, it doesn't activate?
Basically, this should be a separate check, prior to "can capture"
There was a problem hiding this comment.
Ye i basically decided to just use the capture block since originally it was meant to be just a way to allow to destroy all cities so it wouldn't matter if the unit was ranged or not, I will change that.
|
Changed it to: |
| if (defender.isDefeated() && defender is CityCombatant && attacker is MapUnitCombatant | ||
| && attacker.unit.hasUnique(UniqueType.CanDestroyCities, checkCivInfoUniques = true)) { | ||
| if (defender.city.isCapital() && attacker.isMelee()) { | ||
| conquerCity(defender.city, attacker) // Capital is captured by only melee units |
There was a problem hiding this comment.
should be "do nothing" because we capture it below anyway
There was a problem hiding this comment.
In fact the melee part isn't interesting
The "and not capital" should be part of the initial large if, and then we don't have any nesting at all
There was a problem hiding this comment.
i just made it into this
if (defender.isDefeated() && defender is CityCombatant && attacker is MapUnitCombatant
&& attacker.unit.hasUnique(UniqueType.CanDestroyCities, checkCivInfoUniques = true) && !defender.city.isCapital()) {
defender.city.destroyCity()
}
shorter and should work per your comment
removed stuff
|
|
||
|
|
||
| // allow any unit to destory cities instead of capturing them unless its a Capital City, also allows non melee units to destroy cities but only melee can capture capital cities | ||
| CanDestroyCities("Can destroy non capital cities", UniqueTarget.Unit, UniqueTarget.Global, |
There was a problem hiding this comment.
What do you mean by this? im not sure what to change since making it be able to destroy cityFilter means a unit should be able to then destroy even cities that they own? tho I suppose i dont think a unit can just attack your own stuff? Still not sure i understand though.
There was a problem hiding this comment.
Actually the more i think about it changing it to cityfilter could work? im still not sure i completely understand what you mean but making it cityfilter could allow it to be more flexible for modders but im not sure if that will even work.
There was a problem hiding this comment.
"Can destroy [cityFilter] cities", and in the documentation add "Cannot destroy capitals" - that's a constant throughout the game and not something special to this unique
still might be broken? doesnt destroy city states as of now
|
updated it, its will probably need to be changed to make it way better but as of right now it seems to not be able to destroy city states even using "Can destroy [in City-State cities] cities". |
| if (defender.isDefeated() && defender is CityCombatant && attacker is MapUnitCombatant) { | ||
| if (!defender.city.isCapital()) { | ||
| val destroyFilters = attacker.unit.getMatchingUniques(UniqueType.CanDestroyCities).flatMap { unique -> | ||
| unique.params[0]?.let { sequenceOf(it) } ?: emptySequence() |
There was a problem hiding this comment.
Param[0] must exist, or else it wouldn't match the unique, so this should just be .map { unique.params[0] }
test check
removed extra bracket
|
i havent completely checked but is it normal that this doesnt destroy city states even with it correctly set? |
|
Should destroying them be not allowed then? since capitals are supposed to be immune? kinda wanted it to be destroyable but still. |
|
so from what i understand this should be correct since city states should be immune as well since its capital? i believe its also same logic as civ 5 with not being able to raze city states? |
|
I updated my fork to see if nay of the newer updates would have broken stuff. |
|
this should now be good as to my understanding city state are counted as a capital? |
Removed the one that allows a unit to destroy all types of cities so now its just 1 unique that allows a unit to destroy non capital non holy cities.
however i believe things like setting mod option to allow razing city may make it work? not sure though.