Skip to content

feature: add denounce lines for nations, sort them by alphabetic order in Nations.json #13739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shwwwa
Copy link
Contributor

@shwwwa shwwwa commented Jul 29, 2025

  • changed a name of the city of Spain
  • added denouncement lines for all nations
  • removed unnecessary spaces, sorted nations by alphabetic
    last thing is to set proper indentation as it was before, but idk what to set in android studio

@yairm210
Copy link
Owner

These are some massive changes to the file - what's going on?
Also, where are these lines from? If you made them up then great; If they're from Civ V, then not great, since those are property of Firaxis and we're legally not allowed to use them

@yairm210
Copy link
Owner

Oh I see you sorted them by name. Please don't, it makes it impossible to see the actual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants