Crash on Start - GrapheneOS

[JohnQMetro]

Is there an existing issue for this?

• I have searched the existing issues

Game Version

4.16.19

Describe the bug

On GrapheneOS, on a Pixel Tablet, after installing from F-Droid, I start, switch to portrait view, and play for a time. When I restart later, the game always crashes. If I reinstall, this does not change. No mods or any other changes.

I have attached the debug output below:

type: crash
osVersion: google/tangorpro/tangorpro:15/BP1A.250505.005/2025062700:user/release-keys
package: com.unciv.app:1137, targetSdk 35
process: com.unciv.app
processUptime: 160 + 328 ms
installer: org.fdroid.fdroid

java.lang.RuntimeException: Unable to destroy activity {com.unciv.app/com.unciv.app.AndroidLauncher}: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object android.view.View.getTag(int)' on a null object reference
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:6155)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:6187)
	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:6472)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:6387)
	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:106)
	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:63)
	at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:133)
	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:103)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2782)
	at android.os.Handler.dispatchMessage(Handler.java:109)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8973)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
	at com.android.internal.os.ExecInit.main(ExecInit.java:50)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object android.view.View.getTag(int)' on a null object reference
	at androidx.core.view.ViewCompat$Api21Impl.setOnApplyWindowInsetsListener(ViewCompat.java:5278)
	at androidx.core.view.ViewCompat.setOnApplyWindowInsetsListener(ViewCompat.java:2962)
	at com.badlogic.gdx.backends.android.keyboardheight.AndroidXKeyboardHeightProvider.close(AndroidXKeyboardHeightProvider.java:66)
	at com.badlogic.gdx.backends.android.AndroidApplication.onDestroy(AndroidApplication.java:306)
	at android.app.Activity.performDestroy(Activity.java:9437)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1576)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:6142)
	... 18 more

Steps to Reproduce

1. Go to '...'
2. Click on '...'
3. Scroll down to '...'
4. See error

Screenshots

No response

Link to save file

No response

Operating System

Android

Additional Information

No response

[yairm210]

I see, this seems to be a LibGDX issue 🤔
I'll see what I can do

[SomeTroglodyte]

"WindowInsetsListener" - another consequence from Google torpedoeing the insets API's?
I almost feel like dropping inset support entirely and loudly blaming it on the Kraken might help - help our nerves.
But - from this it doesn't even look like the thing has any insets.

But "If I reinstall, this does not change." - any uninstall clears data, right? So our settings file would be gone and the situation shouldn't differ from before the "play a while". Very strange.

[yairm210]

Looks like this

The answer is to "wait for 1.14.0" :|

[JohnQMetro]

But "If I reinstall, this does not change." - any uninstall clears data, right? So our settings file would be gone and the situation shouldn't differ from before the "play a while". Very strange.

To clarify, this means that the problem still occurs on the second install, so I can start it once, play a bit, and then it will crash on every start after that.

But I suppose this is now dealt with. Wait until LibGDX 1.14.

[SomeTroglodyte]

Or... The the Gdx fixing PR patches two overrides. Both would be overridable when subclassed, so - override onDestroy in AndroidLauncher and do the other fix by subclassing AndroidXKeyboardHeightProvider separately and injecting the instance into the backing field via reflection. might have the same effect.

Pity I can't try or test, my local clone no longer builds android - it doesn't see the module. Dunno why. Also prevents syntax highlighting or ctrl-B into gdx source.

[SomeTroglodyte]

my local clone no longer builds android

That must have been #12325. Studio has been finding the Sdk so far without help, why am I now required to set that env variable before launching Studio? That practically means our out-of-the-box instructions might need to specify that. I believe Installing Studio from scratch, neither directly, nor through JetBrains toolbox, will set that system-wide, not for Linux.

So that fixed the main things (missing run config, no ./gradlew android:*), but I still have no working libGdx source integration (no ctrl-B on their classes), so still a ways to go until I can try that mad idea...

[SomeTroglodyte]

#12864 🙈

[SomeTroglodyte]

apk's no longer fit in repos (or else I'd use https://github.com/SomeTroglodyte/Scratchpad/tree/master/Debug%20apk's)...

Here: https://drop.picasoft.net/r/WGTJ5EAa#Kg+hyWq4IM1HtIJDfhrpSc8KhBi1l8aZvfAn/YVX74Q=
is an apk version with a really dirty hack compiled in that emulates the changes from the Gdx fixing PR.
It's debug-signed and therefore cannot be installed as update to store- or release- provided Unciv, nor can it be installed side-by-side. That means data loss. But if you're crashing anyway, you might be curious enough to test it? Mind you: it's a shot in the dark, and I cannot properly test the interesting aspect of it locally, just that it doesn't crash on my device.

[JohnQMetro]

I'm afraid the modified build still crashes when trying to start for the second time:

type: crash
osVersion: google/tangorpro/tangorpro:15/BP1A.250505.005/2025062700:user/release-keys
package: com.unciv.app:1139, targetSdk 35
process: com.unciv.app
processUptime: 2758 + 75 ms
installer: com.android.packageinstaller

java.lang.RuntimeException: Unable to destroy activity {com.unciv.app/com.unciv.app.AndroidLauncher}: java.lang.NullPointerException: null cannot be cast to non-null type android.view.View
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:6155)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:6187)
	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:6472)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:6387)
	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:106)
	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:63)
	at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:133)
	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:103)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2782)
	at android.os.Handler.dispatchMessage(Handler.java:109)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8973)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:927)
Caused by: java.lang.NullPointerException: null cannot be cast to non-null type android.view.View
	at com.unciv.app.AndroidLauncher$onCreate$newKeyboardHeightProvider$1.close(AndroidLauncher.kt:68)
	at com.unciv.app.AndroidLauncher.onDestroy(AndroidLauncher.kt:143)
	at android.app.Activity.performDestroy(Activity.java:9437)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1576)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:6142)
	... 16 more

[SomeTroglodyte]

Thank you for trying though! Sorry, but as I said I, was just trying to shoe-horn the changes I saw in the libGdx PR supposed to solve this into our direct subclasses of the affected Gdx classes. No guarantee that even takes.
Next thing we could do would be to fuse Unciv with a libGdx built from source¹ - but all the links how it's built now are geared to downloadable, published releases. Much more work even if the idea is simpler. Hmmm... do they have a roadmap out for 1.4? Given the current stable is only 6 weeks old...

No wait - A: 1.13.5 includes libgdx/libgdx#7569 which might be worth another shot in the dark, and B: there are snapshots of Gdx on maven-snapshots, though I forgot how exactly to tell Gradle to use one of those.

Hmmm........

Footnotes

1. Not sure it's worth it, but I am curious. ↩

[SomeTroglodyte]

As said, another shot in the dark - if you're still willing to help: Unciv without hacks but using Gdx 1.3.5 - one release later than our releases do. Same debug key, meaning if the last one is still installed, you should be able to update and see the effect right away - if any...

https://drop.picasoft.net/r/2wDMp2yo#TmJxs28GSeMu76I6VmLjtUNj0RBtwryIx1KbMQpcMdQ=

[JohnQMetro]

Good.It no longer crashes on restarting.

[SomeTroglodyte]

Really? Hey wow what a nice surprise 👍 🥳 💯 🎆 🚀 ☘ . Better initiate the process to upgrade the main Unciv to that Gdx version then.

Warning: Don't get too attached. To go back to another source, you'll need to do a full uninstall first. Because of the signing keys. That means app's data gone. Workaround: Save the game you want to keep using "save to external" or whatever the button was called. What you place this way in, say, Documents, won't get deleted. Means any mods will need re-download, but that's simpler than migrating the data using root. Simply load from external will offer to download missing mods for you. Won't help with mods activated as permanent audiovisual though.

[yairm210]

There are several different error reports for 1.13.5 for Android, but looking through them they may not be relevant to our use-case.
We can try, I guess? I can create a "-libgdx-1.13.5" tagged release for testing, but since the maintainers themselves do not recommend 1.13.5 for Android, I'm hesitant to move our entire release to that. Suddenly breaking lots of people's games on update is a real concern in this case.