XWIKI-23413: Separators in navigation tree dropdown #4403
Conversation
* Provided the fix as a hard-coded exception to the updated bootstrap
* Fixed indentation
| @@ -51,6 +51,16 @@ | |||
| text-decoration: none; | |||
| } | |||
| } | |||
|
|
|||
| // We override the separator styles from bootstrap dropdown.less | |||
There was a problem hiding this comment.
To me, it's absolutely not clear why bootstrap dropdowns should have separators by default. I think the separators should be specifically added where we want them and not generically in all bootstrap dropdowns. What's the reason for adding them by default?
There was a problem hiding this comment.
Addressed in bc941a9 👍
* Removed changes relative to the former solution * Reverted generic changes from XWIKI-22485 to make them more specific and added them in the Livedata CSS.
|
Following #4403 (comment) , the solution implemented in the PR completely changed. As for tests, I could build the livedata webjar successfully with |
I assume this is the same as before? Is it normal that the button for the menu is cut off at the top? |
|
@michitux With any livedata with not much into it, it happened for a while now AFAIK. 2025-08-06.11-06-09.mp4 |
* Reverted generic changes from XWIKI-22485 to make them more specific and added them in the Livedata CSS. (cherry picked from commit 4a209c2)
* Reverted generic changes from XWIKI-22485 to make them more specific and added them in the Livedata CSS. (cherry picked from commit 4a209c2)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* Reverted generic changes from XWIKI-22485 to make them more specific and added them in the Livedata CSS. (cherry picked from commit 4a209c2)
* Reverted generic changes from XWIKI-22485 to make them more specific and added them in the Livedata CSS. (cherry picked from commit 4a209c2)
Jira URL
https://jira.xwiki.org/browse/XWIKI-23413
Changes
Description
* Provided the fix as a hard-coded exception to the updated bootstrapThe solution prooposed in this PR now is completely different to what was done initially
Screenshots & Video
With the changes in the PR applied:
Note that before applying that patch, I could reproduce the problem reported on this local instance. The state of this UI without the fix is available as an attachment to the equivalent jira ticket.
Executed Tests
Manual tests only. The issue was reported after manual tests and style changes only hardly ever impact automated tests.
Built the jar with the quality profile successfully:
mvn clean install -f xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar -PqualityExpected merging strategy