Improve code generation for nearbyhint under -ffast-math #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenlau
reviewed
Jun 24, 2025
| // FIXME: it may be better to emit a memory barrier here (?). | ||
| #ifdef __FAST_MATH__ | ||
| volatile batch_type d0 = v + t2n; | ||
| batch_type d = *(batch_type*)(void*)(&d0) - t2n; |
Contributor
There was a problem hiding this comment.
Only cosmetics, but should this use a more modern cast?
Contributor
Author
There was a problem hiding this comment.
well, it's removed
serge-sans-paille
force-pushed
the
bug/548
branch
from
c7a8675 to
90da351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #548