Separated SOURCE and HEADER from SRC #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a variable SRC was used, including ttyclock.c and ttyclock.h, for both dependencies and the C compiler call. This led to incompatibilities with stricter C compiler, like clang.
|
Here's the separate pull request for the Makefile and I must admit that was a good catch on your side, as simply removing the header file from SRC would have led to a missing dependency for building the binary 🙂 I hope you will find this pull request more thoughtful with regard to its implications on the Makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a variable SRC was used, including ttyclock.c and ttyclock.h, for both dependencies and the C compiler call.
This led to incompatibilities with stricter C compiler, like clang.