Skip to content

Enhancement to API for View: Return ViewRowData #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 4, 2025

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Jul 30, 2025

  • Remove unnecessary and undocumented _meta pointer in BaseRow
  • Provide new documented class for the object that is returned, with dynamic support for looking up leafRows.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler requested a review from haynesjm42 July 30, 2025 15:32
@lbwexler lbwexler changed the title Remove BackPointerToRow Remove Back Pointer To Row Jul 30, 2025
@lbwexler lbwexler changed the title Remove Back Pointer To Row Enhancement to API for View. Return ViewRowData Jul 31, 2025
@lbwexler lbwexler changed the title Enhancement to API for View. Return ViewRowData Enhancement to API for View: Return ViewRowData Jul 31, 2025
Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - started to read through, ended up editing/enhancing (I hope) a bunch of doc comments as I tried to understand this system again. Don't know that I quite understand it yet, but certainly didn't see any issues and am eager to adapt the small number of _meta usages I know of to the new API - seems like it will be a big improvement!

private _leafMap: Map<StoreRecordId, LeafRow> = null;
private _recordMap: Map<StoreRecordId, StoreRecord> = null;
_aggContext: AggregationContext = null;
_rowCache: Map<string, BaseRow> = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a map of all rows (at all levels?) by their BaseRow.id?

Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been great to re-engage with our data package here.

The API updates seem like clear improvements - make me eager to add some more long-desired features, but I can hold back on my wishlist for future merges.

I would be happy for this to be merged at any point, but to be clear I haven't attempted to replicate or asses any findings around memory retention or the actual changes that prompted this work. And apols for blowing up the size of the changeset here with all of my comment updates - it was a good prompt to take another pass over all of that, didn't mean to hijack this PR so much. :)

@haynesjm42 leave it to you and Lee if there's anything else you want to suggest or test on this before merging and continuing the investigations.

# Conflicts:
#	CHANGELOG.md
#	data/cube/Cube.ts
@lbwexler lbwexler merged commit 129a37d into develop Aug 4, 2025
2 checks passed
@lbwexler lbwexler deleted the removeBackPointerToRow branch August 4, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants