This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix NullReferenceException thrown in PopupRenderer.SetViewController #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using in embedded forms scenario
SkyeHoefling
previously approved these changes
Dec 10, 2021
pictos
reviewed
Dec 10, 2021
| } | ||
| else | ||
| { | ||
| currentPageRenderer = Platform.GetRenderer(mainPage); | ||
| ViewController ??= currentPageRenderer.ViewController; |
There was a problem hiding this comment.
Are we sure that we just want to set the ViewController if it's null?
There was a problem hiding this comment.
previously, we always set it. it was done by CreateControl. it was the only 1 place where we set it.
now we also set ViewController in ctor. we do not want to set it here again.
hope I correctly understand your question.
TheCodeTraveler
previously requested changes
Dec 17, 2021
src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/iOS/PopupRenderer.ios.cs
Outdated
Show resolved
Hide resolved
TheCodeTraveler
dismissed
their stale review
Null Forgiving Operator removed ✅
pictos
reviewed
Dec 20, 2021
| if (modalStackCount > 0) | ||
| { | ||
| var index = modalStackCount - 1; | ||
| page = page!.Navigation!.ModalStack![index]; | ||
| page = page?.Navigation.ModalStack[index]; |
There was a problem hiding this comment.
if ModalStack is > 0 Page will not be null
There was a problem hiding this comment.
I know, but we receive an error if remove null propagation. and we discussed not to use Null forgiving operator
There was a problem hiding this comment.
rewrite it and add check page for null
pictos
approved these changes
Dec 20, 2021
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Issues Fixed
PR Checklist
approved