Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix popup default color and dark mode #1041

Merged
merged 10 commits into from
Mar 13, 2021
Merged

[iOS] Fix popup default color and dark mode #1041

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b0d7252
[iOS] Fix popup default color and dark mode
geskill Mar 6, 2021
7cb3b33
[Android] Set correct background for default color
geskill Mar 6, 2021
c731d10
[Android] GetWindowColor() for popup background color
geskill Mar 7, 2021
576a141
Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Andr…
AndreiMisiukevich Mar 7, 2021
dc74e73
Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Andr…
AndreiMisiukevich Mar 7, 2021
884a351
Update BasePopup.shared.cs
geskill Mar 8, 2021
0541c61
Merge branch 'develop' into patch-1
TheCodeTraveler Mar 9, 2021
afeaa4b
Update PopupRenderer.android.cs
geskill Mar 12, 2021
3d5ca0a
Update PopupRenderer.android.cs
geskill Mar 12, 2021
414d6db
Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Base…
AndreiMisiukevich Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Android/PopupRenderer.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using Xamarin.Forms;
using Xamarin.Forms.Platform.Android;
using static Android.App.ActionBar;
using AColorRes = Android.Resource.Color;
using AView = Android.Views.View;
using FormsPlatform = Xamarin.Forms.Platform.Android.Platform;
using GravityFlags = Android.Views.GravityFlags;
Expand Down Expand Up @@ -125,7 +126,7 @@ void SetEvents(in BasePopup basePopup)
basePopup.Dismissed += OnDismissed;
}

void SetColor(in BasePopup basePopup) => Window?.SetBackgroundDrawable(new ColorDrawable(basePopup.Color.ToAndroid()));
void SetColor(in BasePopup basePopup) => Window?.SetBackgroundDrawable(new ColorDrawable(basePopup.Color.ToAndroid(AColorRes.BackgroundLight, Context)));

void SetSize(in BasePopup basePopup)
{
Expand Down
2 changes: 1 addition & 1 deletion src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/BasePopup.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public abstract class BasePopup : VisualElement
/// </summary>
protected BasePopup()
{
Color = Color.White;
Color = Color.Default;
Copy link
Contributor Author

@geskill geskill Mar 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, all of that can be removed, because we have the bindable default values.

	Color = Color.Default;
	VerticalOptions = LayoutOptions.CenterAndExpand;
	HorizontalOptions = LayoutOptions.CenterAndExpand;

VerticalOptions = LayoutOptions.CenterAndExpand;
HorizontalOptions = LayoutOptions.CenterAndExpand;
IsLightDismissEnabled = true;
Expand Down