Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Device) #9144

Merged
merged 4 commits into from
Aug 17, 2020
Merged

[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Device) #9144

merged 4 commits into from
Aug 17, 2020

Conversation

1iveowl
Copy link
Contributor

@1iveowl 1iveowl commented Jan 9, 2020 •
edited by samhouts
Loading

Description of Change

Fix touch conflict between Shell Flyout and SwipeView (on Device).

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

See provided UITest

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@dnfclas
Copy link

dnfclas commented Jan 9, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@PureWeen PureWeen requested a review from jsuarezruiz January 10, 2020 02:17
@1iveowl
Copy link
Contributor Author

1iveowl commented Jan 10, 2020

@jsuarezruiz

From the repro and UITest I can see that it is currently the speed of the swipe that determines if the swipe is being picked up by the Shell Menu or by the SwipeView.

Slower swipes are picked up by the SwipeView, while faster swipes are picked up by the Shell Menu.

I’ve looked at the iOS SwipeView Renderer, but I cannot identify a root cause from this. The issue is too tricky for my current understanding of how Shell and SwipeView is constructued.

I was hoping that you might have some insights here?

Thanks

@jsuarezruiz jsuarezruiz changed the title Repro and UITest for Issue 9088 [iOS] Fix touch conflict between Shell Flyout and SwipeView (on Device) Mar 6, 2020
@jsuarezruiz
Copy link
Contributor

@1iveowl Thank you very much for your PR. With the repro sample it has been easier to fix the issue. I have applied changes to your PR to add the fix and have verified it in simulator and devices.

jsuarezruiz
jsuarezruiz suggested changes Mar 6, 2020
View reviewed changes
@samhouts samhouts self-requested a review March 9, 2020 17:18
@samhouts samhouts self-assigned this Mar 9, 2020
@jsuarezruiz
Copy link
Contributor

@samhouts Should we retarget this to 4.5?

@samhouts samhouts added the Core label Mar 12, 2020
@samhouts

This comment has been minimized.

Sign in to view
@samhouts samhouts requested review from PureWeen and removed request for StephaneDelcroix and samhouts March 24, 2020 17:52
@samhouts samhouts assigned PureWeen and unassigned samhouts Mar 24, 2020
@samhouts samhouts changed the base branch from master to 4.6.0 April 3, 2020 22:26
@samhouts samhouts force-pushed the fix-9088 branch 2 times, most recently from 1e5c014 to 2dc4cee Compare April 3, 2020 22:44
@rmarinho
Copy link
Member

rmarinho commented Jun 4, 2020

@1iveowl can you rebase? thanks

@samhouts samhouts changed the base branch from 4.6.0 to 4.7.0 June 8, 2020 21:49
@PureWeen PureWeen changed the base branch from 4.7.0 to main June 30, 2020 21:31
@PureWeen PureWeen changed the base branch from main to 4.7.0 June 30, 2020 21:36
@samhouts samhouts changed the base branch from 4.7.0 to 4.8.0 July 8, 2020 18:06
@samhouts samhouts changed the base branch from 4.8.0 to main July 30, 2020 00:10
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 4, 2020
@samhouts samhouts changed the base branch from main to 5.0.0 August 17, 2020 22:05
@samhouts samhouts merged commit 6f85535 into xamarin:5.0.0 Aug 17, 2020
myroot pushed a commit to myroot/Xamarin.Forms that referenced this pull request Aug 19, 2020
@1iveowl @myroot
[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Devic…
be16900 
…e) (xamarin#9144)

* start

* Start

* UI Test compete

* Added cast SwipeView issue fix

Co-authored-by: Jasper Hedegaard Bojsen <[email protected]>
Co-authored-by: Javier Suárez Ruiz <[email protected]>

fixes xamarin#9088
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this pull request Aug 20, 2020
@1iveowl @sung-su
[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Devic…
062e4d1 
…e) (xamarin#9144)

* start

* Start

* UI Test compete

* Added cast SwipeView issue fix

Co-authored-by: Jasper Hedegaard Bojsen <[email protected]>
Co-authored-by: Javier Suárez Ruiz <[email protected]>

fixes xamarin#9088
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this pull request Aug 20, 2020
@1iveowl @sung-su
[iOS] Fix touch conflict between Shell Flyout and SwipeView (on Devic…
3c1253d 
…e) (xamarin#9144)

* start

* Start

* UI Test compete

* Added cast SwipeView issue fix

Co-authored-by: Jasper Hedegaard Bojsen <[email protected]>
Co-authored-by: Javier Suárez Ruiz <[email protected]>

fixes xamarin#9088
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

@PureWeen PureWeen

@jsuarezruiz jsuarezruiz

Labels
a/collectionview a/gestures 🖖 a/maps 🌐 a/shell 🐚 a/swipeview a/visual ControlGallery Core p/Android p/gtk p/iOS 🍎 p/macOS p/Tizen p/UWP p/WPF retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. t/bug 🐛
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] SwipeView items conflict with Shell menu swipe in from left, on real iOS devices
6 participants
@1iveowl @dnfclas @jsuarezruiz @samhouts @rmarinho @PureWeen