Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Modal Page with transparent background #8551

Merged
merged 14 commits into from
Mar 24, 2020
Merged

Modal Page with transparent background #8551

merged 14 commits into from
Mar 24, 2020

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Nov 18, 2019 •
edited by PureWeen
Loading

Description of Change

Takeover from #6558

Issues Resolved

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis jfversluis added t/enhancement ➕ DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. p/iOS 🍎 p/Android ControlGallery labels Nov 18, 2019
@jfversluis jfversluis requested a review from PureWeen November 18, 2019 14:10
@jfversluis
Copy link
Member Author

jfversluis commented Nov 18, 2019 •
edited
Loading

Added DNM because I need to process a last piece of feedback from the review on the old PR by @PureWeen, here: #6558 (comment)

Other than that I think I have processed all feedback

Edit: oh, and because I added Automatic which is iOS 13 this will not build until we can update to Xcode 11 :(

@YZahringer
Copy link
Contributor

UWP support is also planned?

@PureWeen PureWeen added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. and removed DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. labels Jan 27, 2020
@PureWeen PureWeen requested a review from jsuarezruiz January 27, 2020 23:59
@samhouts samhouts self-requested a review January 28, 2020 01:11
@samhouts samhouts self-assigned this Jan 28, 2020
@jsuarezruiz
Copy link
Contributor

@YZahringer Yes.
transparent-modal-uwp

@samhouts samhouts added the p/UWP label Jan 28, 2020
@PureWeen PureWeen mentioned this pull request Jan 29, 2020
Closed
@SkyeHoefling SkyeHoefling mentioned this pull request Feb 7, 2020
Closed
3 tasks
@GalaxiaGuy GalaxiaGuy mentioned this pull request Feb 18, 2020
Closed
7 tasks
@jfversluis jfversluis mentioned this pull request Feb 25, 2020
Merged
2 tasks
@sasivishnu
Copy link

@jfversluis @PureWeen any update on this? we are on track of getting this in first 4.5 release? Thanks..

@PureWeen
Copy link
Contributor

As of now this is planned for 4.6

@jsuarezruiz it looks like we have some UI tests failures. Can you rebase against master and we can rerun?

@jfversluis
Copy link
Member Author

These tests fail for iOS 11 and 12 and I also have seen these fail in the previous test run. Oddly enough for iOS 13 there are others and they seem unrelated. I will look into them though.

image

@dansiegel
Copy link
Contributor

great to see some traction on this! really looking forward to seeing this merged!

@PureWeen PureWeen force-pushed the modal-transparent branch from ecbf4a2 to e69d693 Compare March 19, 2020 02:14
@PureWeen
Copy link
Contributor

Android tests passed here
https://dev.azure.com/xamarin/public/_releaseProgress?_a=release-pipeline-progress&releaseId=1392

Which is why most recent run only has iOS

PureWeen
PureWeen reviewed Mar 20, 2020
View reviewed changes
@samhouts samhouts removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Mar 24, 2020
@samhouts samhouts requested review from PureWeen and removed request for jsuarezruiz March 24, 2020 17:55
@samhouts samhouts assigned PureWeen and unassigned jsuarezruiz Mar 24, 2020
@samhouts samhouts removed the request for review from StephaneDelcroix March 24, 2020 17:56
@PureWeen PureWeen merged commit d103974 into 4.6.0 Mar 24, 2020
@PureWeen PureWeen deleted the modal-transparent branch March 24, 2020 22:58
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Mar 25, 2020
@samhouts samhouts added this to the 4.6.0 milestone Mar 31, 2020
@mhrastegari
Copy link
Contributor

@YZahringer Yes.
transparent-modal-uwp

The current UWP Modal pages doesn't have a back button(plus Android , iOS) or a page animation, but it does exist in your GIF! Is it planned too?

@dinesh4official
Copy link

@PureWeen , @samhouts can you please share any documentation regarding this one?

@dinesh4official
Copy link

@PureWeen , @samhouts , Can you check the below report?

#10861

@PureWeen PureWeen mentioned this pull request Jun 26, 2020
Merged
2 tasks
@dansiegel dansiegel mentioned this pull request Aug 21, 2020
Open
@gentledepp
Copy link
Contributor

@jfversluis this introduces a bug when you mave more than one modal level....
I will create a PR soon - please have an additional look!

@gentledepp gentledepp mentioned this pull request Jan 25, 2021
Closed
@PureWeen PureWeen mentioned this pull request Mar 3, 2021
Closed
This was referenced May 18, 2022
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@samhouts samhouts samhouts approved these changes

Assignees

@PureWeen PureWeen

@samhouts samhouts

Labels
a/lifecycleevents a/modal a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. ControlGallery iOS 13 p/Android p/iOS 🍎 p/UWP t/bug 🐛 t/enhancement ➕
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

[Bug] OnAppearing does not fire after a UIModalPresentationStyle.FormSheet Page is Dismissed [Bug] Page not popped on iOS 13 FormSheet swipe down