This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] Color.Accent is hardcoded #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On Android Color.Accent is set to a hardcoded value in Xamarin.Forms.Forms.SetupInit (in the Platform.Android project) and it cannot be changed by the user.
This color is then used as text and separator color for TableSections. The user cannot override the color.
As the hardcoded color may not fit to the users app theme, this should be changed.
Jason Smith said on forms-devel that the code should read from the current Android theme. This change does that.
I wouldn't know how to unit test this.
Bugs Fixed
API Changes
None
Behavioral Changes
Color.Accent will be set to the accentColor of the current Android theme instead of the hardcoded values.
PR Checklist