Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Android] Color.Accent is hardcoded #270

Merged
merged 1 commit into from
Aug 2, 2016
Merged

[Android] Color.Accent is hardcoded #270

merged 1 commit into from
Aug 2, 2016

Conversation

MichaelRumpler
Copy link
Contributor

@MichaelRumpler MichaelRumpler commented Jul 26, 2016

Description of Change

On Android Color.Accent is set to a hardcoded value in Xamarin.Forms.Forms.SetupInit (in the Platform.Android project) and it cannot be changed by the user.

This color is then used as text and separator color for TableSections. The user cannot override the color.

As the hardcoded color may not fit to the users app theme, this should be changed.

Jason Smith said on forms-devel that the code should read from the current Android theme. This change does that.

I wouldn't know how to unit test this.

Bugs Fixed

API Changes

None

Behavioral Changes

Color.Accent will be set to the accentColor of the current Android theme instead of the hardcoded values.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas
Copy link

dnfclas commented Jul 26, 2016

Hi @MichaelRumpler, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, DNFBOT;

@jassmith jassmith merged commit 08e2823 into xamarin:master Aug 2, 2016
@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants