This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix 15329 NavigationBarSeparator is visible after changing BarBackgroundColor when SetHideNavigationBarSeparator(true) #15330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustickDM
changed the title
|
Thanks so much for your help here @JustickDM ! I'm sorting out some things right now also related to builds... I will have a look at this asap :) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix-15329
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Thanks so much for your very first contribution @JustickDM! Go out, be proud and tell everyone you are a Xamarin.Forms contributor now!
|
@jfversluis Thanks so much too:) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add method UpdateHideNavigationBarSeparator after UpdateBarBackground on HandlePropertyChanged (Xamarin.Forms.Platform.iOS/Renderers/NavigationRenderer.cs)
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
NavigationBarSeparator is Hidden when the BarBackgroundColor is changed
Before/After Screenshots
Before:
After:
Testing Procedure
PR Checklist