This repository was archived by the owner on May 1, 2024. It is now read-only.
fix the calculations of the needed size of a ScollView on Android (Issue 15100) #15101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heikow10 would you be able to confirm that this is still necessary in the latest version of Xamarin.Forms? I know we did some fix(es) in the meanwhile for the |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Yep, this seems still needed. Verified that this issue doesn't exist in .NET MAUI. Thanks for another great contribution @heikow10 ! |
|
@jfversluis My response is a little bit late. But I can confirm that the fix was still relevant. So thanks for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The calculations of the needed size of a ScollView on Android do now always consider all Margins of its child view and all Paddings of the ScrollView.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Now a ScrollView takes up all the space needed by the size of its child view, the Margins of the child view and the Paddings of the ScrollView.
So it is possible to see the complete child view and the complete Padding/Margin surrounding the child view.
Before/After Screenshots
Testing Procedure
PR Checklist