This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] Fix crash trying to update a removed tab menu item #14661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
reviewed
Oct 19, 2021
| @@ -537,13 +537,19 @@ void OnPagePropertyChanged(object sender, PropertyChangedEventArgs e) | |||
|
|
|||
| if (IsBottomTabPlacement) | |||
| { | |||
| IMenuItem tab = _bottomNavigationView.Menu.GetItem(index); | |||
| tab.SetTitle(page.Title); | |||
| if (_bottomNavigationView.Menu.Size() > index) | |||
There was a problem hiding this comment.
Should this be just >? For all the checks here? Does it then also work for the last tab? Maybe we should add a test page for this?
jfversluis
approved these changes
Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In #11301 clearing the pages was invoking this code https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs#L540 also in the removed page. Trying to update and get the item, the index does not fit with the collection count.
Added some validations to svoid update the items title or icon if, the index is out of range.
Issues Resolved
API Changes