This repository was archived by the owner on May 1, 2024. It is now read-only.
Build AppX packages before doing Solution Restore to fix UWP UI tests #12935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
changed the title
PureWeen
added
t/housekeeping ♻︎
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For 16.8.* we had to add a "/restore" call to the msbuild operation we use to build the nugets. This seems to put the ControlGallery appx files into a weird state where they can't be deployed because of some dependency confusion.
This PR moves the APPX build part to happen before the nugets are packaged which seems to work
Testing Procedure
PR Checklist