This repository was archived by the owner on May 1, 2024. It is now read-only.
When popping multiple pages remove middle pages first #12331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
approved these changes
Oct 7, 2020
|
Test failures unrelated |
samhouts
approved these changes
Oct 9, 2020
|
|
||
| // populate global routes and build modal stacks | ||
|
|
||
| // If the currentNavStack is larger than _navStack then we have modal pages | ||
| bool weveGoneTotalModal = currentNavStack.Count > _navStack.Count; |
rachelkang
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a number of optimization for interpreting a new route and trying to minimize the amount of operations that happen
GotoAsync("../..")just remove the middle pages before popping the currently visible page. This way OnAppearing won't fire on pages being removed and they won't appear and then disappear/page1/page2' and then you want to navigate to/page1/page3' it will now first push page3 and then remove page2 so that you never see page 1/page1/page2/page3and you navigate to `/page1/page3' it'll just remove page2Platforms Affected
Behavioral/Visual Changes
Users will no longer see the middle when the user is requesting that multiple pages pop. The middle pages will no longer throw "OnAppearing" and then "OnDisappearing" as they are popped
Testing Procedure
PR Checklist