Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Fix the DisplayActionSheet #12188

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

shyunMin
Copy link
Contributor

@shyunMin shyunMin commented Sep 21, 2020

Description of Change

This PR includes two changes as below

  • Fix DisplayActionSheet to be displayed properly on Mobile(F-hub)
  • Add null check for Text value

Issues Resolved

None

API Changes

None

Platforms Affected

  • Tizen

Behavioral/Visual Changes

F-hub(Before) F-hub(After)

And, It will be displayed on other profiles as following.

  • TV

  • Mobile

  • Wearable

Before/After Screenshots

The action items will be shown as a button without any style.

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove existing public API.

@samhouts samhouts requested review from hartez and samhouts September 21, 2020 18:42
@rmarinho rmarinho merged commit 7200e07 into xamarin:5.0.0 Sep 22, 2020
@samhouts samhouts added this to the 5.0.0 milestone Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants