This repository was archived by the owner on May 1, 2024. It is now read-only.
Only require 14393+ for UWP class libraries #10368 #10713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotMorten
changed the title
|
/azp run |
|
No pipelines are associated with this pull request. |
PureWeen
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This only warns for UWP class library projects if you target less than 14393. Class libraries doesn't require being built for 17763. That's a requirement for an app.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
No useless warning that can't otherwise be disabled/removed
Before/After Screenshots
Not applicable
Testing Procedure
Build a UWP class library that targets 10.0.17134 and observe the build error before/after.
Build a UWP app, and notice there's no change in warnings.
PR Checklist