PHP 8.4 | Fix implicitly nullable parameters #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a `null` default value, which are not explicitly declared as nullable. As this code base still has a minimum supported PHP version of PHP 5.6, changing these parameters to explicitly nullable is not an option as that syntax was only introduced in PHP 7.1. With that in mind, I'm proposing to change the default value of the parameters to comply with the type declaration. Even though this is not a `final` class, this is not a breaking change for two reasons: 1. The signature check does not get applied to constructors. 2. Even if it did, default values can be different between parent vs child, as long as they comply with the expected type. Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
swissspidy
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a
nulldefault value, which are not explicitly declared as nullable.As this code base still has a minimum supported PHP version of PHP 5.6, changing these parameters to explicitly nullable is not an option as that syntax was only introduced in PHP 7.1.
With that in mind, I'm proposing to change the default value of the parameters to comply with the type declaration.
Even though this is not a
finalclass, this is not a breaking change for two reasons:Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types