Skip to content

Feat: snapshot listeners #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Feat: snapshot listeners #235

wants to merge 18 commits into from

Conversation

wovalle
Copy link
Owner

@wovalle wovalle commented Feb 23, 2021

Still missing:

  • Revisit documentation
  • Add missing unit tests (like ignoreEmptyUpdates)
  • Add the ability to listen changes in entities (not only collections)
  • Return docChanges to the user (maybe as the second param of the watch callback?)

garviand and others added 18 commits February 8, 2021 18:12
@garviand
feat(query): add POC for QuerySnapshot events
6b52236
@garviand
fix(documentation): fix watch documentation to make sense
435be7b
@garviand
fix(tests): give snapshot tests unique col name
c20c6ac
@garviand
feat(query): add types to watch query
8cf1a92
@garviand
feat(query): remove unnecessary test types
a7be392
@garviand
feat(query): change arguments to generic types for watch
8f5e64f
@garviand
feat(query): update watch argument name in types
8b73dcd
@garviand
feat(query): update types for watch query
881e211
@garviand
feat(query): remove unnecessary casting
a383666
@garviand
feat(query): add missing type to watch
5b99a95
@garviand
feat(query): remove unused import
86fdd1e
@garviand
feat(query): remove another unused import
b10c704
@garviand
fix: remove rebase conflict
b42a11d
@garviand
feat: cast queryResult as T[] in findOne
ac23cdf
@garviand
test: rename snapshot integration test filename to fit new standard
179fc80
@wovalle
Merge pull request #218 from garviand/snapshots
0af8e58 
feat: implement snapshot listeners
@wovalle
chore: fixing linter
53329bb
@wovalle
chore: adding ignoreEmptyUpdates to snapshot listeners and other changes
e5c1f92
@Leeaandrob
Copy link

What do we need to finish this PR?

@dcsan
Copy link

dcsan commented Jun 5, 2023

is this PR the main way to use firestore's realtime capabilities? wonder if it will be merged

is there a way to get at the underlying firestore collections from a firerom model so we can mix raw firebase API calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wovalle @Leeaandrob @dcsan @garviand