Dropped 3rd-party dependencies #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipp
requested review from
SeanROlszewski,
andy-t-wang,
decentralgabe,
m1guelpf and
sideround
as code owners
| Digest(bytes: Self.computeDigest(for: buffer)) | ||
| } | ||
|
|
||
| private static func computeDigest(for message: [UInt8]) -> [UInt8] { |
There was a problem hiding this comment.
Did you write this code or get it from elsewhere? I'm concerned that the only bounds checking here leads to an unconditional program termination.
If we get a message that doesn't fit into the buffer (either due to an accident or something malicious), I don't think we should always crash the client process in production. I think it's probably better to abort the computation and signal something anomalous happened, and let the clients determine what to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.