Add caching to remote JWKS fetch #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknisi
force-pushed
the
nicknisi/cached-jwks
branch
from
3749120 to
87e28cd
Compare
PaulAsjes
suggested changes
Jan 16, 2025
Contributor
PaulAsjes
left a comment
PaulAsjes
left a comment
There was a problem hiding this comment.
Small naming nit, otherwise good!
nicknisi
force-pushed
the
nicknisi/cached-jwks
branch
from
2f20578 to
c2f5db1
Compare
PaulAsjes
approved these changes
Jan 16, 2025
indicate that it's in seconds very explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a cache module and tests, and then uses that to cache the return value of fetching JWKS per
client_id.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
Fixes #334