Update Aspire to 13.0.0 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldbarre-workleap
temporarily deployed
to
ci
GitHub Actions
Inactive
geraldbarre-workleap
temporarily deployed
to
ci
GitHub Actions
Inactive
geraldbarre-workleap
temporarily deployed
to
ci
GitHub Actions
Inactive
geraldbarre-workleap
temporarily deployed
to
ci
GitHub Actions
Inactive
geraldbarre-workleap
temporarily deployed
to
ci
GitHub Actions
Inactive
Copilot finished reviewing on behalf of
geraldbarre-workleap
November 20, 2025 21:09
There was a problem hiding this comment.
Pull Request Overview
This PR updates .NET Aspire from version 9.5.2 to 13.0.0, which includes a breaking API change requiring migration from the lifecycle hook pattern to an eventing-based pattern. The update also includes related dependency upgrades.
- Migration of all lifecycle hooks from
IDistributedApplicationLifecycleHooktoIDistributedApplicationEventingSubscriberwith the new eventing pattern - Update of Microsoft.Extensions.* packages from 9.0.11 to 10.0.0
- Update of various other dependencies including Spectre.Console, NuGet.Protocol, and Microsoft.Identity.Client packages
- Minor code refactoring to simplify null-checking pattern
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Leap.Cli/Leap.Cli.csproj | Updates Aspire SDK and packages from 9.5.2 to 13.0.0, Microsoft.Extensions.* from 9.0.11 to 10.0.0, and other dependency version bumps |
| src/Workleap.Extensions.Leap/Workleap.Extensions.Leap.csproj | Updates Microsoft.Extensions packages from 9.0.11 to 10.0.0 |
| src/Leap.Testing/Leap.Testing.csproj | Updates Microsoft.Extensions.Http.Polly from 9.0.11 to 10.0.0 |
| src/Leap.Cli.Tests/Leap.Cli.Tests.csproj | Updates Spectre.Console.Testing from 0.53.0 to 0.54.0 |
| src/Leap.Cli.Tests/LeapTests.cs | Adds blank line after namespace declaration (formatting) |
| src/Leap.Cli/Platform/Telemetry/TelemetryHelper.cs | Refactors null check to use null-conditional operator for cleaner code |
| src/Leap.Cli/Pipeline/StartAzureCliDockerProxyPipelineStep.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Pipeline/PrepareReverseProxyPipelineStep.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Aspire/UseLeapCertificateForAspireDashboardLifecycleHook.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Aspire/ReverseProxyEndpointExtensions.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Aspire/EnableAspireDashboardDiagnosticLoggingLifecycleHook.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Aspire/DotnetExecutableResource.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Aspire/DockerComposeResourceLifecycleHook.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent and reorganizes imports |
| src/Leap.Cli/Aspire/DockerComposeResourceExtensions.cs | Updates registration from TryAddLifecycleHook to TryAddEventingSubscriber |
| src/Leap.Cli/Aspire/DistributedApplicationBuilderExtensions.cs | Updates registration from TryAddLifecycleHook to TryAddEventingSubscriber |
| src/Leap.Cli/Aspire/DetectDotnetBuildRaceConditionErrorLifecycleHook.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
| src/Leap.Cli/Aspire/AspireManager.cs | Updates registrations from TryAddLifecycleHook to TryAddEventingSubscriber and IDistributedApplicationLifecycleHook to IDistributedApplicationEventingSubscriber |
| src/Leap.Cli/Aspire/AspireDashboardReadinessAwaiter.cs | Migrates lifecycle hook to new eventing subscriber pattern with BeforeStartEvent |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geraldbarre-workleap
temporarily deployed
to
ci
GitHub Actions
Inactive
PrincessMadMath
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue link: feng-1466
Description of changes
Breaking changes
Additional checks