Skip to content

Add height, width on symbol #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add height, width on symbol #4

merged 3 commits into from
Oct 25, 2023

Conversation

anthony-redFox
Copy link
Contributor

@wooorm
Copy link
Owner

wooorm commented Oct 24, 2023

This project is generated from specs. Did you run the scripts? Otherwise your changes will be immediately undone.

@anthony-redFox
Copy link
Contributor Author

Thanks for suggestion to run script. I add manually attributes because it is bug in spec - w3c/svgwg#803

Signed-off-by: Titus <[email protected]>
@anthony-redFox
Copy link
Contributor Author

Update xo - it is related sindresorhus/eslint-plugin-unicorn#2117

@wooorm
Copy link
Owner

wooorm commented Oct 24, 2023

Thanks!

You can run the scripts locally btw: npm test.
Now it looks like TS wants "lib": ["es2021"], in tsconfig.json, or maybe even es2022?

@anthony-redFox
Copy link
Contributor Author

done

@wooorm wooorm changed the title Add width and height as support by symbol Add height, width on symbol Oct 25, 2023
@wooorm wooorm merged commit a024b85 into wooorm:main Oct 25, 2023
@wooorm
Copy link
Owner

wooorm commented Oct 25, 2023

released, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants