fix: ensure profile creation order #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix includes two changes: - Ensure that local storage is updated before sending the message to service worker. - Use correctly the api to create context menus that is callback based.
DanSM-5
force-pushed
the
fix/profiles-wrong-behavior
branch
from
245aea7 to
eb49007
Compare
|
@woodruffw The CI is failing for the linting of the ruby and python scripts which were not touched by this. |
Yeah, that's because I've just been lazy about fixing them. No worries about those. |
woodruffw
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix includes two changes:
Fixes: #133