Make the calendar view include grants, proposals, milestones #1552

valyefimov · 2023-03-02T12:09:57Z

📌 References

Wonder issue:
Related pull-requests: https://github.com/wondrous-dev/wondrous-backend/pull/725/files

📘 Description

🎥 Screenshot or Video

https://www.loom.com/share/714b30cdc94e48de84bf953bfe0a6329

🍰 Checklist:

I self-reviewed my changes
My changes follow the style guide: https://creative-earth-33e.notion.site/TT-Wonder-Style-guide-4702a45133374148953bfcaf584120b7
I tested my changes in Chrome

vercel · 2023-03-02T12:10:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wonderverse-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 3, 2023 8:42pm
wondrous-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 3, 2023 8:42pm

…age-for-all

…age-for-all # Conflicts: # wondrous-app/components/organization/wrapper/BoardPageHeader.tsx # wondrous-app/graphql/fragments/task.ts

andywong418

Great stuff! Just a couple of questions

andywong418 · 2023-03-21T06:54:07Z

wondrous-app/components/CalendarPage/index.tsx

+    date: null,
+    fromDate: startOfMonth(new Date()),
+    labelId: null,
+    limit: 1000,


Is there a reason we're not paginating here?

makes sense to paginate data

for day view - load more when you scroll down

for week view - load more when the user clicks "Show more" button and scrolls down

Yes exactly!

wondrous-app/components/Settings/Integrations/SnapshotConfig.tsx

andywong418 · 2023-03-21T07:04:15Z

wondrous-app/components/CalendarPage/constants.tsx

+      ],
+    },
+    // {
+    //   name: 'labelId',


Do we need this commented code?

no, we don't. I'll remove it

…age-for-all

valyefimov · 2023-03-28T13:16:11Z

@andywong418 @terryli0095
I've tried to implement the loading when you scroll feature in order to consume fewer resources. However, I have encountered some challenges when trying to find the right solution. For the month view, I've to get 3 records (tasks, bounties, grants, and proposals) for every day, and in order to do this, I need to write a heavy SQL query that probably won't use indexes.

Additionally, when a user opens the modal to view more tasks, I need to load more tasks/bounties, proposals, milestones, and grants. This means I need to keep track of the count and current index for every entity. I have tried multiple solutions for this, but I have not found a perfect one yet.

So, the solution I have implemented is to leave the limit to 1000 and load all tasks/bounties, proposals, milestones, and grants for the month/week view. However, I only display a limited count to not render all and load more when the user scrolls down. For the week view, I display only 10 records for a day and added a "view more" button (similar to what we have for the month view).

I understand that this may not be the ideal solution, but I believe it's the best option given the requirements and challenges I've encountered.

feat: calendar page

4d8cd84

valyefimov added the WIP Work in progress label Mar 2, 2023

valyefimov changed the title ~~wip: make the calendar view include more stuff, like grants, proposals, milestones, on to the same page~~ wip: make the calendar view include grants, proposals, milestones Mar 2, 2023

vercel bot deployed to Preview – wondrous-app March 2, 2023 12:12 View deployment

vercel bot deployed to Preview – wonderverse-web March 2, 2023 12:13 View deployment

Merge remote-tracking branch 'origin/staging' into feature/calendar-p…

0615c79

…age-for-all

vercel bot deployed to Preview – wondrous-app March 7, 2023 23:16 View deployment

vercel bot deployed to Preview – wonderverse-web March 7, 2023 23:17 View deployment

feat: display all task types in the calendar

1e14699

vercel bot deployed to Preview – wonderverse-web March 10, 2023 22:24 View deployment

Merge remote-tracking branch 'origin/staging' into feature/calendar-p…

3467cb7

…age-for-all

vercel bot deployed to Preview – wonderverse-web March 10, 2023 22:28 View deployment

vercel bot deployed to Preview – wondrous-app March 10, 2023 22:32 View deployment

valyefimov added 2 commits March 15, 2023 23:05

feat: improve filters for the calendar page

9241b64

feat: improve code for org calendar

c7ca6e9

vercel bot deployed to Preview – wonderverse-web March 16, 2023 23:09 View deployment

vercel bot had a problem deploying to Preview – wondrous-app March 16, 2023 23:10 Failure

fix: few issues for the calendar on the collaboration page

11deea0

vercel bot deployed to Preview – wonderverse-web March 17, 2023 22:44 View deployment

Merge remote-tracking branch 'origin/staging' into feature/calendar-p…

0ea2184

…age-for-all # Conflicts: # wondrous-app/components/organization/wrapper/BoardPageHeader.tsx # wondrous-app/graphql/fragments/task.ts

valyefimov added Ready for code review Backend dependencies test manually and removed WIP Work in progress labels Mar 17, 2023

vercel bot deployed to Preview – wonderverse-web March 17, 2023 22:49 View deployment

vercel bot deployed to Preview – wondrous-app March 17, 2023 22:52 View deployment

fix: create common function to build task url

80452ff

valyefimov changed the title ~~wip: make the calendar view include grants, proposals, milestones~~ feat: make the calendar view include grants, proposals, milestones Mar 17, 2023

valyefimov marked this pull request as ready for review March 17, 2023 22:54

valyefimov self-assigned this Mar 17, 2023

valyefimov requested review from Lamperoyge, andywong418 and terryli0095 and removed request for Lamperoyge March 17, 2023 23:02

andywong418 reviewed Mar 21, 2023

View reviewed changes

vercel bot deployed to Preview – wonderverse-web March 24, 2023 13:50 View deployment

vercel bot had a problem deploying to Preview – wondrous-app March 24, 2023 13:51 Failure

valyefimov changed the title ~~feat: make the calendar view include grants, proposals, milestones~~ wip: make the calendar view include grants, proposals, milestones Mar 26, 2023

valyefimov added WIP Work in progress and removed Ready for code review labels Mar 26, 2023

vercel bot deployed to Preview – wonderverse-web March 26, 2023 22:49 View deployment

vercel bot had a problem deploying to Preview – wondrous-app March 26, 2023 22:50 Failure

feat: lore more task on scroll for the month/day view

e972280

valyefimov changed the title ~~wip: make the calendar view include grants, proposals, milestones~~ Make the calendar view include grants, proposals, milestones Mar 28, 2023

valyefimov added Ready for code review and removed WIP Work in progress labels Mar 28, 2023

valyefimov force-pushed the feature/calendar-page-for-all branch from f6ae3ee to e972280 Compare March 28, 2023 12:38

valyefimov added 2 commits March 28, 2023 14:38

Merge remote-tracking branch 'origin/staging' into feature/calendar-p…

246eab7

…age-for-all

Merge remote-tracking branch 'origin/staging' into feature/calendar-p…

b9b744f

…age-for-all

vercel bot deployed to Preview – wonderverse-web March 28, 2023 12:44 View deployment

vercel bot deployed to Preview – wondrous-app March 28, 2023 12:48 View deployment

valyefimov requested a review from andywong418 March 28, 2023 13:16

Merge branch 'staging' into feature/calendar-page-for-all

1c5b3d5

andywong418 approved these changes Apr 3, 2023

View reviewed changes

vercel bot deployed to Preview – wonderverse-web April 3, 2023 20:38 View deployment

vercel bot deployed to Preview – wondrous-app April 3, 2023 20:42 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make the calendar view include grants, proposals, milestones #1552

Make the calendar view include grants, proposals, milestones #1552

Uh oh!

valyefimov commented Mar 2, 2023 •

edited

Loading

Uh oh!

vercel bot commented Mar 2, 2023 •

edited

Loading

Uh oh!

andywong418 left a comment

Uh oh!

andywong418 Mar 21, 2023

Uh oh!

valyefimov Mar 21, 2023

Uh oh!

andywong418 Mar 22, 2023

Uh oh!

Uh oh!

andywong418 Mar 21, 2023

Uh oh!

valyefimov Mar 21, 2023

Uh oh!

valyefimov commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Make the calendar view include grants, proposals, milestones #1552

Are you sure you want to change the base?

Make the calendar view include grants, proposals, milestones #1552

Uh oh!

Conversation

valyefimov commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 References

📘 Description

🎥 Screenshot or Video

🍰 Checklist:

Uh oh!

vercel bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andywong418 left a comment

Choose a reason for hiding this comment

Uh oh!

andywong418 Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

valyefimov Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

andywong418 Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andywong418 Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

valyefimov Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

valyefimov commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

valyefimov commented Mar 2, 2023 •

edited

Loading

vercel bot commented Mar 2, 2023 •

edited

Loading