feat: add existing members to member request page #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SankhaChak
changed the title
terryli0095
reviewed
Jan 11, 2023
| keyArgs: ['input', ['orgId', 'podIds', 'date', 'statuses', 'priorities']], | ||
| merge: offsetLimitPaginationInput, | ||
| }, | ||
| getOrgUsers: offsetLimitPagination(['orgId', 'searchString', 'roleIds', 'limit']), |
There was a problem hiding this comment.
why do we want to remove this limit?
There was a problem hiding this comment.
I guess this was a mistake, we shouldn't consider any key with combination to the limit key to identify a new request. Do you have any thoughts on this @Lamperoyge ?
terryli0095
reviewed
Jan 11, 2023
…tPodMembershipRequest query
terryli0095
force-pushed
the
feat/add-existing-members-to-member-request-page
branch
from
f452314 to
eb72872
Compare
terryli0095
reviewed
Jan 11, 2023
terryli0095
reviewed
Jan 11, 2023
wondrous-app/graphql/queries/org.ts
Outdated
| lastName | ||
| bio | ||
| additionalInfo { | ||
| podCount |
There was a problem hiding this comment.
this is actually the wrong data, this is total pod count across organizations. let's just remove the pod count field
…members-to-member-request-page
terryli0095
reviewed
Jan 16, 2023
terryli0095
reviewed
Jan 16, 2023
terryli0095
reviewed
Jan 16, 2023
terryli0095
reviewed
Jan 16, 2023
terryli0095
reviewed
Jan 16, 2023
…members-to-member-request-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
https://github.com/wondrous-dev/wondrous-backend/pull/674
https://github.com/wondrous-dev/wondrous-backend/pull/686
📘 Description
Add existing members to org and pod members page with the ability to filter using username / wallet address and / or roles
🎥 Screenshot or Video
https://www.loom.com/share/8cd59ab1cfc249ff92117500f386cdc6
🍰 Checklist: