scan: make max db allowed build age configurable #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
k4leung4
reviewed
Jul 14, 2025
| // DisableSBOMCache controls whether the scanner will cache SBOMs generated from | ||
| // APKs. If true, the scanner will not cache SBOMs or use existing cached SBOMs. | ||
| DisableSBOMCache bool | ||
| } | ||
|
|
||
| // DefaultOptions is the recommended default configuration for a new Scanner. | ||
| // These options are suitable for most use scanning cases. | ||
| var DefaultOptions = Options{} | ||
| var DefaultOptions = Options{ | ||
| MaxAllowedBuildAge: 120 * time.Hour, |
There was a problem hiding this comment.
are we planning to keep the 120 permanently or temporary?
There was a problem hiding this comment.
This is a temporary change, I've added a warning suggesting a recommended age. I also added a note to the code.
There was a problem hiding this comment.
this seems really confusing
we have a recommended age of 48hrs, but default to 120hrs
i guess until we better understand the reasoning behind the 48hr
i would recommend keeping the default behavior and allowing users to avoid it as necessary
rather than setting a new default that really shouldnt be the default
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
hectorj2f
force-pushed
the
change_max_allowed_build_age
branch
from
9f74f2d to
aaffeec
Compare
rawlingsj
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the current default value for the grype configuration max-allowed-built-age to 120h as in Grype. We currently set it to 48h.
We made this change to temporary overcome this issue on the upstream grype repo https://github.com/anchore/grype-db/actions/workflows/daily-db-publisher-r2.yaml which has been failing during the last 2 days.