nodejs-16.yaml: Add openssf-options

[justinvreeland]

No description provided.

[octo-sts]

Gen AI suggestions to solve the build error:

• Detected Error: Build failure in V8/ICU compilation with error messages:

/usr/include/unicode/stringpiece.h:134:23: error: 'is_same_v' is not a member of 'std'; did you mean 'is_same'?
/usr/include/unicode/localpointer.h:561:26: error: 'auto' parameter not permitted in this context

• Error Category: Build/Dependency

• Failure Point: V8 compilation failing due to C++14 standard being used with ICU headers requiring C++17 features

• Root Cause Analysis: The build is using C++14 standard (-std=gnu++14) but ICU headers are using C++17 features like std::is_same_v and auto non-type template parameters

• Suggested Fix:

1. Update the compile flags in the pipeline to use C++17:

  - name: Configure and build
    runs: |
      # Add C++17 flag
      export CXXFLAGS="${CXXFLAGS} -std=gnu++17"
      
      # Rest of the existing configure/build commands

• Explanation: The ICU library headers are using C++17 features but V8/Node.js is being compiled with C++14. Upgrading to C++17 will provide the required language features needed by ICU while remaining compatible with Node.js 16.x requirements.

• Additional Notes:

• Node.js 16.x is compatible with C++17
• The ICU version installed (75.1) requires C++17 features
• This is a common issue when building Node.js with newer ICU versions
• There are some non-critical warnings that can be ignored about escape sequences

• References:

• ICU C++ requirements: https://unicode-org.github.io/icu/userguide/icu4c/build.html
• Node.js 16.x build requirements: https://github.com/nodejs/node/blob/v16.x/BUILDING.md
• Relevant Node.js issue: https://github.com/nodejs/node/issues/39678

[dannf]

Questions inline, but no objection to merging as-is.

[dannf]

At any rate, nothing noted is a regression, so +1