set RNG on curve25519 keys to support blinding #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with curve25519 shared secret generation by ensuring the key context has the proper RNG configured when blinding is enabled.
- Conditionally sets the RNG on both private and public curve25519 keys under the WOLFSSL_CURVE25519_BLINDING flag.
- Adjusts the order of key caching and shared secret generation to use the updated key contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream wolfSSL broke wolfHSM after it turned on curve25519 blinding by default, which requires setting RNG on key context for shared secret generation. Found out the hard way after updating wolfSSL to latest master. This PR fixes.