Eliminate unnecessary reassignment of isLastBlock in SHA-256 processing

[Jpgig]

The current code in the xferSha256BlockAndUpdateDigest function in wh_client_cryptocb.c file contains a redundant operation:
Copy Code
if (isLastBlock) {
// Code for handling the last block
} else {
isLastBlock = 0; // Redundant assignment
}
Issue Analysis
This code has a logical inefficiency:
• isLastBlock is checked in the if-condition
• If isLastBlock is already 0 (false), the else block sets it to 0 again
• This assignment has no effect as the value remains unchanged
Recommendation
This redundant assignment can be safely removed without affecting functionality:
Copy Code
if (isLastBlock) {
// Code for handling the last block
}
// No else block needed
The optimization is safe because:

1. Setting a variable to the same value it already holds is unnecessary
2. No side effects appear to be associated with this assignment
3. Removing it will slightly improve code readability and efficiency
   Unless there's some non-obvious reason for this redundant assignment?