Skip to content

Conversation

@dolmen
Copy link
Contributor

@dolmen dolmen commented Feb 28, 2025

  • Fuzz Base64LineBreaker with various chunk sizes
  • Check the count of written bytes reported by the base64 encoder

- Fuzz Base64LineBreaker with various chunk sizes
- Check the count of written bytes reported by the base64 encoder
@wneessen
Copy link
Owner

Thanks for the PR @dolmen. Much appreciated. Code looks good to me and will be merged.
Out of curiosity, did you already give the new fuzzing code a longer run and was it able to find anything?

@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (24dad49) to head (12e837f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   94.34%   93.35%   -1.00%     
==========================================
  Files          30       30              
  Lines        3534     3534              
==========================================
- Hits         3334     3299      -35     
- Misses        147      187      +40     
+ Partials       53       48       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen wneessen merged commit 3978049 into wneessen:main Feb 28, 2025
28 checks passed
@dolmen
Copy link
Contributor Author

dolmen commented Feb 28, 2025

I came here by looking for duplications of the lineBreaker code in encoding/pem.

See CL 653675 and CL 653676.

@dolmen dolmen deleted the more-Base64LineBreaker-fuzzing branch April 2, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants