Skip to content

Conversation

@sonalys
Copy link
Contributor

@sonalys sonalys commented Nov 6, 2024

Please, accept this review for fixing a panic on the .Close() method.

wneessen pushed a commit that referenced this pull request Nov 6, 2024
Introduce a unit test to ensure that invoking Close on a nil smtpclient instance returns nil without errors. This enhances the robustness of the client closure functionality. This test accommodates the fix provided with PR #353
@wneessen
Copy link
Owner

wneessen commented Nov 6, 2024

Thanks for catching this and providing the PR @sonalys! Much appreciated. Additionally I've created PR #354, so this case is covered by our test suite to make sure we don't introduce a regression for this at some point.

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (9ca7d24) to head (8c4eb62).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   91.74%   90.55%   -1.19%     
==========================================
  Files          27       27              
  Lines        2944     2944              
==========================================
- Hits         2701     2666      -35     
- Misses        172      212      +40     
+ Partials       71       66       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen wneessen merged commit 632ac17 into wneessen:main Nov 6, 2024
28 of 29 checks passed
@sonalys
Copy link
Contributor Author

sonalys commented Nov 6, 2024

Could you create a minor release for this issue?

I think it's a very critical one. It's happening for me, and I have to go around it with a defer recover.

@wneessen
Copy link
Owner

wneessen commented Nov 6, 2024

Yes, that should be possible.

@sonalys sonalys deleted the fix/close_panic branch November 6, 2024 10:22
@wneessen
Copy link
Owner

wneessen commented Nov 6, 2024

v0.5.2 is now released: https://github.com/wneessen/go-mail/releases/tag/v0.5.2

@sonalys
Copy link
Contributor Author

sonalys commented Nov 6, 2024

v0.5.2 is now released: https://github.com/wneessen/go-mail/releases/tag/v0.5.2

You are supersonic! Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants