Skip to content

Improved client error testing #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Improved client error testing #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fbebcf9
Add simple SMTP test server for unit testing
Sep 20, 2024
0aa24c6
Add methods to retrieve message ID and message from SendError
Sep 20, 2024
6af6a28
Add test for SendError with no encoding
Sep 20, 2024
b8f0462
Add error handling tests for SMTP client
Sep 20, 2024
482194b
Add TestClient_SendErrorReset to validate SMTP error handling
Sep 20, 2024
157c138
Fix linter errors
Sep 20, 2024
d5437f6
Remove redundant comments from sleep statements
Sep 20, 2024
8dfb121
Update Go versions in GitHub Actions workflow
Sep 20, 2024
bd5a8a4
Fix error handling in Send method in client_119.go
Sep 20, 2024
4ee11e8
Refactor SMTP server port handling in tests
Sep 20, 2024
44df830
Add tests for SendError MessageID and Msg methods
Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
go: ['1.20', '1.21', '1.22', '1.23']
go: ['1.19', '1.20', '1.23']
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
Expand Down
10 changes: 8 additions & 2 deletions client_119.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,22 @@

package mail

import "errors"

// Send sends out the mail message
func (c *Client) Send(messages ...*Msg) error {
if err := c.checkConn(); err != nil {
return &SendError{Reason: ErrConnCheck, errlist: []error{err}, isTemp: isTempError(err)}
}
var errs []*SendError
for _, message := range messages {
for id, message := range messages {
if sendErr := c.sendSingleMsg(message); sendErr != nil {
messages[id].sendError = sendErr
errs = append(errs, sendErr)

var msgSendErr *SendError
if errors.As(sendErr, &msgSendErr) {
errs = append(errs, msgSendErr)
}
}
}

Expand Down
Loading
Loading