Skip to content

Conversation

wlcrs
Copy link
Owner

@wlcrs wlcrs commented May 24, 2025

Fixes #955 . Both internal and external power meter sensors have been added. As I don't have any way to detect which one is active, I went with the following approach:

  • all external power meter sensors are disabled by default.
  • only the most important internal power meter sensors are enabled.

This code is untested as I don't own/have access to an EMMA installation.

I would be grateful if somebody would test this code and let me know if there are issues. Please also mention what type of power meter your setup uses, as I want to have covered both type of installations before merging this code into the next release of the integration.

@radumarinoiu
Copy link

radumarinoiu commented May 28, 2025

I just tried this, seems to be adding more entities to the EMMA device, but the names are not showing up properly (for the new, disabled sensors as well as some existing disabled sensors? Not sure here, there's a ton of disabled sensors for me).

The entity ids are also not really obvious: emma_power_2, emma_power_3, emma_power_4, and so on, same for basically all the disabled ones as well as some of the ones that got enabled by default, I cannot tell what they represent.
Oh, also, the names of the disabled sensors are just "Voltage", "Voltage", ..., "Current", "Current", you get the point

Let me know if there's anything specific you need me to try.

@popescunsergiu
Copy link

I’ve tested the functionality by updating all six files that differed between feature/emma-power-meter-sensors, main, and 1.5.4. I removed and re-added the integration, and after doing so, all entities appear to work correctly and the integration is functioning as expected.

The only issue I still see is the one already reported regarding the incorrect entity names.

Many thanks to Thijs for this awesome integration!

@wlcrs wlcrs merged commit a04b59d into main Jun 30, 2025
5 checks passed
@wlcrs
Copy link
Owner Author

wlcrs commented Jun 30, 2025

The issue with the generic sensor names is being caused by the translation files that are not yet updated. I've merged this PR and will now let Crowdin pick up the new sensors to translate (cfr. #1040).

@wlcrs wlcrs deleted the feature/emma-power-meter-sensors branch June 30, 2025 06:21
@artcrime
Copy link

I’ve tested the functionality by updating all six files that differed between feature/emma-power-meter-sensors, main, and 1.5.4. I removed and re-added the integration, and after doing so, all entities appear to work correctly and the integration is functioning as expected.

The only issue I still see is the one already reported regarding the incorrect entity names.

Many thanks to Thijs for this awesome integration!

How did you manage to see the sensors from the external meter? I deleted the whole integration and readied it. But I don't find the entities.
My external meter is a DDSU666-H connected directly via modbus to Emma to meter my small pv on the garage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: EMMA external CT values do not show
4 participants