Cleanup, added requirements.txt #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Addition] Added a requirements.txt to make it easier to install needed python packages [Bugfix] Fixed syntax errors that had unneeded semicolons and func calls that had missing parentheses [Refactor] Refactored str2bool(): + Function now accepts falsey values + Replaced tuple literal with a set literal (Faster time complexity with in operator) + If a non-valid param is entered, will raise an exception [Refactor] Replaced a lengthy use of string concats with a f-string [Refactor] Simplified some logical expressions in if statements [Refactor] Made exceptions in except blocks include error description when logged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I see this python file has some syntax issues so I figured I'd try and clean things up, I cannot test this code nor know how so I advise to test this first before merging
[Addition] Added a requirements.txt to make it easier to install needed python packages (Needs confirmation if using correct packages and package versions)
[Bugfix] Fixed syntax errors that had unneeded semicolons and func calls that had missing parentheses
[Refactor] Refactored
str2bool():[Refactor] Replaced a lengthy use of string concats with a f-string in
updateOSD()[Refactor] Simplified some logical expressions in if statements
[Refactor] Made exceptions in except blocks include error description when logged