Skip to content

Conversation

ascorbic
Copy link
Contributor

Changes

Back in the day, endpoints were special-cased to ignore trailing slash rules and always have it set to ignore. This turned out to break things, so it was removed for file-based endpoint routes in #9597. However injected endpoints were left out of that fix, meaning there was still the bug for them.

Fixes #13105

Testing

Added tests

Docs

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: ab3c9df

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #13111 will not alter performance

Comparing inject-endpoints (ab3c9df) with main (187c4d3)

Summary

✅ 6 untouched benchmarks

@ascorbic ascorbic merged commit 23978dd into main Jan 31, 2025
16 checks passed
@ascorbic ascorbic deleted the inject-endpoints branch January 31, 2025 14:57
@astrobot-houston astrobot-houston mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Injected endpoints with trailingSlash: 'always' are not accessible
3 participants