feat(sessions): implement ttl and flash #12693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: astro
|
Can you update the RFC with the relative information, so we can review the PR? |
|
@ematipico the RFC has been updated |
ematipico
reviewed
Dec 9, 2024
Comment on lines
+2
to
+3
| Astro.session.flash('flash-value', `Flashed value at ${new Date().toISOString()}`); | ||
| return Astro.redirect('/'); |
There was a problem hiding this comment.
Can we add more cases, such as:
- usage with
Astro.rewrite - usage with the
next("/some-route")(the other form of rewrite): see if the value changes when the next middleware function read from.flash - usage with multiple middleware functions e.g.
sequence(fn1, fn2)
ematipico
approved these changes
Dec 10, 2024
| this.#data ??= new Map(); | ||
| this.#data.set(key, value); | ||
| const lifetime = ttl ?? this.#config.ttl; | ||
| const expires = typeof lifetime === 'number' ? Date.now() + lifetime * 1000 : lifetime; |
There was a problem hiding this comment.
Can we add a comment that explains the 1000?
ematipico
added a commit
that referenced
this pull request
Dec 18, 2024
* wip: experimental sessions * feat: adds session options (#12450) * feat: add session config * chore: add session config docs * Fix * Expand doc * Handle schema * Remove example * Format * Lock * Fix schema * Update packages/astro/src/types/public/config.ts Co-authored-by: Sarah Rainsberger <[email protected]> * Update packages/astro/src/types/public/config.ts Co-authored-by: Sarah Rainsberger <[email protected]> * Add link to Sessions RFC in config.ts * Move session into experimental --------- Co-authored-by: Sarah Rainsberger <[email protected]> * Lock * feat: prototype session support (#12471) * feat: add session object * Add tests and fix logic * Fixes * Allow string as cookie option * wip: implement sessions (#12478) * feat: implement sessions * Add middleware * Action middleware test * Support URLs * Remove comment * Changes from review * Update test * Ensure test file is run * ci: changeset base * ci: exit from changeset pre mode * Lockfile * Update base * fix: use virtual import for storage drivers (#12520) * fix: use virtual import for storage drivers * Don't try to resolve anythign in build * Fix test * Polyfill node:url * Handle custom drivers directly * No need for path * Update packages/astro/src/core/session.ts Co-authored-by: Emanuele Stoppa <[email protected]> --------- Co-authored-by: Emanuele Stoppa <[email protected]> * Fix jsdoc * fix: set default storage path * Update changeset config for now * Revert config workaround * Lock * Remove unneeded ts-expect-error directive * fix: [sessions] import storage driver in manifest (#12654) * wip * wip * Export manifest in middleware * Changeset conf * Pass session to edge middleware * Support initial session data * Persist edge session on redirect * Remove middleware-related changes * Refactor * Remove vite plugin * Format * Simplify import * Handle missing config * Handle async resolution * Lockfile * feat(sessions): implement ttl and flash (#12693) * feat(sessions): implement ttl and flash * chore: add unit tests * Make set arg an object * Add more tests * Add test fixtures * Add comment * Remove session.flash for now (#12745) * Changeset * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <[email protected]> --------- Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for session data expiry. This includes:
ttlconfig optionttlargument tosetsession.flash(), which expires the data after the next requestTesting
Added unit tests
Docs