-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Adds Tailwind v4 support #10376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Tailwind v4 support #10376
Conversation
🦋 Changeset detectedLatest commit: 18cb0dc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Jacob Jenkins <[email protected]>
Co-authored-by: Jacob Jenkins <[email protected]>
I have talked it out the the discord under A. I can't measure the size clearly Resources Looked at: |
Well all of the code LGTM. I can't wait till I can use tailwind v4 in astro! |
This was discussed in the #contribute channel yesterday, and there was discussion of maybe deprecating/removing In which case, do we need an Astro integration that simply applies the |
Well we still need the extensions cause less code = less cluttered and most people perfer to use the integrations I felt like we could just make it add a tw.css file to css and make index page import it. |
Yeah I get the reason why but at the same time wouldn't users rather have a command to add the part that does it for them, cause remember developers are lazy. Lets take this in a scenario where you are a developer using a framework do you want to use a simple command that does for you or do you want to hard code it by your self which takes more time. Which one would you choose? |
Plus compatibility with sass/scss requires one file for my end for every project to add tailwind support. rather I can use a plugin/intergration that add |
I have started a thread in the discord to talk about this extensively but I really agree to a comment from the #contibute channel from @alexanderniebuhr saying maybe we should still keep it there but tell the user to import it |
The PR Is ON HOLD since it's not really required as Tailwind v4 Is in alpha when Tailwind V4 is in schedule for it's beta or stable release we would reconsider the implementation. For now if you want to use tailwind v4 I would use the astro-tailwind-v4 community intergration for now. Any more discussions can be located on the discord thread here for any issues, questions or other things about tailwind v4 support |
Let's wait for tailwind v4 to stabilise, or until there's a reason v4 requires additional Astro setup before add some support for it. Closing this for now. |
PR ONHOLD: commit about it here
This PR is for the offical support for tailwind v4
Changes
package.json
to export the new v4 changes and adds@tailwind/vite
package.v4.ts
andbase-v4.css
for tailwind v4 support.Testing
Testing done. Only type errors for
AstroIntergration
,config
,updateConfig
andinjectScript
.Docs
You will need to update the docs to tell people how to use the v4 edition of the TailwindCSS to change the import to
@astrojs/tailwind/v4