-
-
Notifications
You must be signed in to change notification settings - Fork 231
Create WireMock.Net.ProtoBuf project #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
==========================================
- Coverage 36.12% 35.29% -0.83%
==========================================
Files 171 150 -21
Lines 37887 34500 -3387
==========================================
- Hits 13685 12177 -1508
+ Misses 23793 21909 -1884
- Partials 409 414 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extracts ProtoBuf functionality from the main WireMock.Net project into a separate WireMock.Net.ProtoBuf
project, improving modularity and enabling optional ProtoBuf support without adding dependencies to the minimal package.
- Removes conditional compilation directives (
#if PROTOBUF
) and replaces them with dynamic type loading - Extracts ProtoBuf-related classes and extension methods to the new project
- Updates interfaces to use abstractions instead of concrete implementations
Reviewed Changes
Copilot reviewed 44 out of 66 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/WireMock.Net.ProtoBuf/ |
New project containing extracted ProtoBuf functionality with matchers, utils, and extension methods |
src/WireMock.Net.Shared/ |
Updated interfaces and utilities to support dynamic loading of ProtoBuf components |
src/WireMock.Net.Minimal/ |
Refactored to use dynamic type loading instead of conditional compilation |
Test files | Updated to reference renamed helper classes and use new ProtoBuf utilities |
Project files | Added new project references and updated package dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
No description provided.