Skip to content

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Aug 24, 2025

No description provided.

@StefH StefH self-assigned this Aug 24, 2025
@StefH StefH added the feature label Aug 24, 2025
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.29%. Comparing base (124d29c) to head (ac480cc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
....Minimal/ResponseBuilders/Response.WithCallback.cs 66.66% 2 Missing ⚠️
...rc/WireMock.Net.Minimal/RequestBuilders/Request.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
- Coverage   36.12%   35.29%   -0.83%     
==========================================
  Files         171      150      -21     
  Lines       37887    34500    -3387     
==========================================
- Hits        13685    12177    -1508     
+ Misses      23793    21909    -1884     
- Partials      409      414       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefH StefH requested a review from Copilot August 25, 2025 05:08
Copilot

This comment was marked as outdated.

@StefH StefH requested a review from Copilot August 25, 2025 17:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts ProtoBuf functionality from the main WireMock.Net project into a separate WireMock.Net.ProtoBuf project, improving modularity and enabling optional ProtoBuf support without adding dependencies to the minimal package.

  • Removes conditional compilation directives (#if PROTOBUF) and replaces them with dynamic type loading
  • Extracts ProtoBuf-related classes and extension methods to the new project
  • Updates interfaces to use abstractions instead of concrete implementations

Reviewed Changes

Copilot reviewed 44 out of 66 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/WireMock.Net.ProtoBuf/ New project containing extracted ProtoBuf functionality with matchers, utils, and extension methods
src/WireMock.Net.Shared/ Updated interfaces and utilities to support dynamic loading of ProtoBuf components
src/WireMock.Net.Minimal/ Refactored to use dynamic type loading instead of conditional compilation
Test files Updated to reference renamed helper classes and use new ProtoBuf utilities
Project files Added new project references and updated package dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@StefH StefH merged commit e5c4605 into master Aug 26, 2025
10 of 11 checks passed
@StefH StefH deleted the split-protobuf branch August 26, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant