-
Notifications
You must be signed in to change notification settings - Fork 333
Fix reauth without password #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8bdc1ce
to
0ab843a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small comment, 👍
testRemoveClient :: Bool -> Brig -> Cannon -> Http () | ||
testRemoveClient hasPwd brig cannon = do | ||
unless hasPwd $ error | ||
"not implemented: for password-less users, we need to figure out another way to login." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For password-less users, I'd just change the test so that no login is performed, i.e., one could simply skip:
-- Permanent client with attached cookie
login brig (defEmailLogin email) PersistentCookie
!!! const 200 === statusCode
numCookies <- countCookies brig uid defCookieLabel
liftIO $ Just 1 @=? numCookies
Exactly |
ci error is unrelated:
|
galley end-points for deleting team members and deleting teams, resp., ask for a password even if the user calling the end-point doesn't have one. we change the behavior to be in sync with the end-points for adding and deleting devices.