Allow setting a different endpoint for generating download links #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the URIs that we hand out to clients to download asset point to an AWS endpoint, namely a S3 or a Cloudfront URL.
In the context of self hosting, and in case users want to host S3 "internally" using minio.io for instance, there should be a publicly addressable URL that cargohold can give out so that they are reachable from the outside world. For instance, let's say that we have the HTTPS endpoint at
wire-https.foo.bar
andcargohold
is configured to talk to a self hosted minio.io athttp://fake-s3:9000
; obviously these URLs are not useful for clients. Instead, one would need to make an endpoint available athttps://wire-fake-s3.foo.bar
which simply proxies requests to minio.io.In order to try this out yourselves, you can set
fake-s3
tolocalhost
on your machines.