Do not deliver client specific notifiations to temporary clients #4703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Also: Only push a notification to RabbitMQ when the user has any clients which support consumable notifications. This way RabbitMQ wouldn't think there are notifications meant for no queues.
akshaymankar
force-pushed
the
less-notifs-for-temp-clients
branch
from
089e314 to
6f64702
Compare
blackheaven
approved these changes
Aug 5, 2025
supersven
reviewed
Aug 5, 2025
akshaymankar
commented
Aug 5, 2025
Co-authored-by: Sven Tennie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: Only push a notification to RabbitMQ when the user has any clients which support consumable notifications.
This way RabbitMQ wouldn't think there are notifications meant for no queues.
https://wearezeta.atlassian.net/browse/WPB-18886
Checklist
changelog.d