Skip to content

WPB-18562 Propagate a rate limit error with status 429 on internal call to reauthenticate #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

WPB-18562 Propagate a rate limit error with status 429 on internal call to reauthenticate #4673

merged 2 commits into from
Jul 23, 2025

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jul 21, 2025 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review July 21, 2025 09:50
@battermann battermann requested review from a team as code owners July 21, 2025 09:50
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 21, 2025
stefanwire
stefanwire approved these changes Jul 21, 2025
View reviewed changes
integration/test/Test/Teams.hs
statusCodes <- for mems $ \m -> do
bindResponse (deleteTeamMember tid owner m) $ \resp -> do
pure resp.status
Set.fromList statusCodes `shouldMatchSet` ([202, 429] :: [Int])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make sure that 429 was returned at least once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually asserts that it's returned at least once. But I might not 100% understand your comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I misread. ✅

@battermann battermann merged commit 5b50820 into develop Jul 23, 2025
8 checks passed
@battermann battermann deleted the WPB-18562-team-member-deletions-causes-lots-of-5-xx-galley-brig-causes-429-on-i-users-reauthenticate-and-alerts branch July 23, 2025 07:26
@zebot zebot mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @stefanwire @zebot