Skip to content

Check consistency of group info #4670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 24, 2025
Merged

Check consistency of group info #4670

merged 14 commits into from
Jul 24, 2025

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jul 17, 2025

This PR adds an optional consistency check of the submitted group info on any commit. The ratchet tree extension is parsed and compared with the index map of the group after the commit is applied.

https://wearezeta.atlassian.net/browse/WPB-18394

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 21, 2025
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2025

CLA assistant check
All committers have signed the CLA.

@pcapriotti pcapriotti marked this pull request as ready for review July 21, 2025 09:24
@pcapriotti pcapriotti requested review from a team as code owners July 21, 2025 09:24
@eyeinsky eyeinsky force-pushed the group-info-check branch 2 times, most recently from e3f2203 to f5fb609 Compare July 22, 2025 08:17
@eyeinsky
Copy link
Collaborator

The CI failed for yesterday's changes, a few of these I think were unrelated to what I did (fake-aws-sqs timed out, upload-hoogle-nix failed), and with one I broke the linter -- the linter thing I fixed and now waiting on CI.

@pcapriotti pcapriotti merged commit ca47e49 into develop Jul 24, 2025
9 checks passed
@pcapriotti pcapriotti deleted the group-info-check branch July 24, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants